test(money): verify check payer DDL safety - #413
Open
Clarion1631 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
Final independent money-path reviewREVIEW: VERDICT: SHIP
No database URL was used. No DDL was run. This comment records review only; the PR was not merged. |
Owner
Author
CI evidenceflowchart LR
PR["PR #413: package + verifier tests"] --> BUILD["Build + bundle ✅"]
PR --> VERCEL["Vercel preview ✅"]
MAIN["Current main baseline"] --> MIG["Migration-shape check ❌"]
PR --> E2E["Playwright: 506 pass / 1 fail / 1 flaky ❌"]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TIMESTAMPTZ(6)verificationtest:bank-ledgerImportant scope note
The implementation under test was already incorporated into
mainby commit854c3eb3(fix(deploy): anchor Users* ignore to repo root) before this clean task branch was prepared. That unrelated deploy commit bundledscripts/apply-check-payer-extraction.mjs. This PR adds the missing verifier evidence only. The task's final independent review covers both that implementation delta and this PR's regression tests.No database URL was used. No DDL was run.
Verification
npx tsx --test tests/apply-check-payer-extraction.test.ts— 6 passednode scripts/apply-check-payer-extraction.mjs --dry-run— SQL printed; nothing executednpm run test:bank-ledger— 527 passed, 1 skipped, 0 failednpx prisma generate && npm run typecheck— passednpx eslint scripts/apply-check-payer-extraction.mjs tests/apply-check-payer-extraction.test.ts— 0 errors; script is ignored by repository lint configgit diff --check origin/main...HEAD— passedRisk
Money-path migration tooling. Review only; do not merge until the task's final independent review is attached.